Skip capturing cookie header when it's set separately #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estolfo
force-pushed
the
cookies
branch
2 times, most recently
from
eb58e68
to
870a24a
Compare
picandocodigo
approved these changes
Nov 28, 2023
picandocodigo
force-pushed
the
cookies
branch
from
870a24a
to
6bd0311
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1402
When there are cookies set at
Cookiein the header and they're captured in the request cookies context field, set the context header value to[SKIPPED].See elastic/apm-agent-nodejs#3322 for more context.