Skip to content

Use stack for mongo spy spans #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Use stack for mongo spy spans #1211

merged 4 commits into from
Dec 16, 2021

Conversation

estolfo
Copy link
Contributor

@estolfo estolfo commented Dec 9, 2021

Instead of relying on the operation id, let's just use a stack to keep track of mongo spy spans.

@apmmachine
Copy link
Contributor

apmmachine commented Dec 9, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-09T11:35:34.612+0000

  • Duration: 26 min 39 sec

  • Commit: 38a5386

Test stats 🧪

Test Results
Failed 0
Passed 46783
Skipped 84
Total 46867

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@estolfo
Copy link
Contributor Author

estolfo commented Dec 9, 2021

@jclusso Do you want to try this PR out? We think it might solve the MongoDB spans issue. Please let us know how it goes!

@jclusso
Copy link
Contributor

jclusso commented Dec 9, 2021

@estolfo giving it a shot now!

@jclusso
Copy link
Contributor

jclusso commented Dec 9, 2021

Looks promising so far. I'll update you after a day or so.
image

@estolfo
Copy link
Contributor Author

estolfo commented Dec 9, 2021

@jclusso Great! We look forward to hearing back tomorrow!

@jclusso
Copy link
Contributor

jclusso commented Dec 10, 2021

@estolfo no luck :( - on the bright side I did find a span that is traced and you can see all the stacktraces that don't make any sense. If you want to coordinate another Zoom, email me - jarrett@cacheventures.com.

@estolfo estolfo merged commit d19a649 into elastic:master Dec 16, 2021
@jclusso
Copy link
Contributor

jclusso commented May 5, 2022

@estolfo I noticed we're still using your fork on the mongo-forking branch. Should we still be using this or is that merged in? I can't find the issue where you told us to give that a try.

@jclusso
Copy link
Contributor

jclusso commented Jun 24, 2022

@estolfo any word on the above?

@estolfo
Copy link
Contributor Author

estolfo commented Jun 30, 2022

Hi @jclusso I responded to your other comment here

@jclusso
Copy link
Contributor

jclusso commented Jun 30, 2022

Not sure why I never got the notification. Thought I had commented but couldn’t find it. Thanks.

estolfo added a commit that referenced this pull request Mar 2, 2023
* Use stack for mongo spy spans

* Add mutex so that the correct current transaction and span are consulted

* current span and transaction are thread locals so we don't need mutexes

* Fix spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants