-
Notifications
You must be signed in to change notification settings - Fork 134
Use stack for mongo spy spans #1211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
@jclusso Do you want to try this PR out? We think it might solve the MongoDB spans issue. Please let us know how it goes! |
@estolfo giving it a shot now! |
@jclusso Great! We look forward to hearing back tomorrow! |
@estolfo no luck :( - on the bright side I did find a span that is traced and you can see all the stacktraces that don't make any sense. If you want to coordinate another Zoom, email me - jarrett@cacheventures.com. |
@estolfo I noticed we're still using your fork on the |
@estolfo any word on the above? |
Not sure why I never got the notification. Thought I had commented but couldn’t find it. Thanks. |
* Use stack for mongo spy spans * Add mutex so that the correct current transaction and span are consulted * current span and transaction are thread locals so we don't need mutexes * Fix spacing
Instead of relying on the operation id, let's just use a stack to keep track of mongo spy spans.