Skip to content

MongoDB: Make sure to end the right spans #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

MongoDB: Make sure to end the right spans #1209

wants to merge 3 commits into from

Conversation

mikker
Copy link
Contributor

@mikker mikker commented Dec 7, 2021

No description provided.

@apmmachine
Copy link
Contributor

apmmachine commented Dec 7, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-07T23:19:29.195+0000

  • Duration: 27 min 12 sec

  • Commit: 22265ad

Test stats 🧪

Test Results
Failed 0
Passed 46783
Skipped 84
Total 46867

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mikker mikker marked this pull request as ready for review December 7, 2021 15:02
@mikker mikker requested a review from estolfo December 7, 2021 15:02
@mikker
Copy link
Contributor Author

mikker commented Dec 7, 2021

@estolfo We're green thanks to you 😊

estolfo
estolfo requested changes Dec 7, 2021
View reviewed changes
mikker and others added 2 commits December 8, 2021 00:19
@mikker @estolfo
Update lib/elastic_apm/spies/mongo.rb
0a6af4a 
Co-authored-by: Emily S <emily.s@elastic.co>
@mikker @estolfo
Update lib/elastic_apm/spies/mongo.rb
22265ad 
Co-authored-by: Emily S <emily.s@elastic.co>
mikker
mikker commented Dec 7, 2021
View reviewed changes
lib/elastic_apm/spies/mongo.rb
@@ -96,9 +96,8 @@ def push_event(event)

def pop_event(event)
span = events.delete(event.operation_id)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the agent is not recording, will this not be a problem? We have an early return in push_event if there's no transaction. Shouldn't we have the same check here?

@estolfo
Copy link
Contributor

estolfo commented Dec 9, 2021

I'm going to close this, as it's superseded by #1211

@estolfo estolfo closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estolfo estolfo estolfo requested changes

Assignees
No one assigned
Labels
agent-ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikker @apmmachine @estolfo