Skip to content

Conversation

xrmx
Copy link
Member

@xrmx xrmx commented Sep 19, 2025

What does this pull request do?

Don't hardcode the apm layer version as 1, in 6.24.0 it's 3. While at it fix vars substitution.

Related issues

Suggest to always check the ARNs listed in the release notes instead of
assuming that the layer version will always be 1.
@xrmx xrmx requested a review from a team as a code owner September 19, 2025 10:30
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link

github-actions bot commented Sep 19, 2025

🔍 Preview links for changed docs

@xrmx xrmx self-assigned this Sep 19, 2025
@@ -46,9 +46,11 @@ To add the layers to your Lambda function through the AWS Management Console:

* APM agent layer:
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these are not substituted in the rendered version

I think you need to add subs=true for each code block (docs).

Suggested change
```
``` subs=true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like we are missing these since the conversion :)

Copy link
Member Author

@xrmx xrmx Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using subs without a specific language syntax raises a warning https://github.com/elastic/apm-agent-python/actions/runs/17862322955/job/50796054339?pr=2430

And with the syntax fixed it doesn't look it's working.

UPDATE: with proper syntax is working fine

Also fix it for code blocks
@xrmx xrmx changed the title docs: clarify that layer version may not be 1 docs: lambda layer version may not be 1 Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants