-
Notifications
You must be signed in to change notification settings - Fork 230
docs: lambda layer version may not be 1 #2430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Suggest to always check the ARNs listed in the release notes instead of assuming that the layer version will always be 1.
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
🔍 Preview links for changed docs |
@@ -46,9 +46,11 @@ To add the layers to your Lambda function through the AWS Management Console: | |||
|
|||
* APM agent layer: | |||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these are not substituted in the rendered version
I think you need to add subs=true
for each code block (docs).
``` | |
``` subs=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks like we are missing these since the conversion :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using subs without a specific language syntax raises a warning https://github.com/elastic/apm-agent-python/actions/runs/17862322955/job/50796054339?pr=2430
And with the syntax fixed it doesn't look it's working.
UPDATE: with proper syntax is working fine
Also fix it for code blocks
a2e5b6d
to
5adecd0
Compare
What does this pull request do?
Don't hardcode the apm layer version as 1, in 6.24.0 it's 3. While at it fix vars substitution.
Related issues