chore: bump min Node.js to v14.17; update deps #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates a number of dependencies now that our base Node.js version is v14. There is some subtlety in the 'pino' and 'glob' deps. They both use AbortController (pino via its usage of readable-stream@4) or <AbortSignal>.reason to support aborting async operations. Full support for these were not added until Node.js 14.17 -- yet this APM agent currently supports back to 14.5.0. I feel this is not an issue. In node 14.x `AbortController` et al are only available behind a flag (`node --experimental-abortcontroller`). Node.js v14.17 added `<AbortSignal>.reason`, so the fail case with Pino is a user using (a) a Node.js version in the range [v14.5, v14.17), and (b) with the `--experimental-abortcontroller` flag, and (c) something in the APM agent's code path tries to use `AbortSignal.reason`. When the flag is not used both readable-stream@4 and glob@10 will use a polyfill. We could consider setting min to >14.17, but I don't currently think it is necessary. Closes: #2760
github-actions
bot
added
the
agent-nodejs
|
Cannot use pino@8 either because its dep pino@7 is not more than a year old: This makes me want to consider bumping our min Node.js to v14.17. It would give us pino@8 (and glob@10, FWIW). Node v14.17 was released 11-May-2021, over 2 years ago (https://nodejs.org/download/release/). OTel JS SDK 1.x base version is I feel I'm agonizing over a minor thing. :) |
trentm
changed the title
After some discussion: let's do it. |
…agent (e.g. the warning about a pre-release version of the APM agent)
david-luna
approved these changes
Sep 6, 2023
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
This bumps the mininum supported Node.js from v14.5 to v14.17; and bumps a number of dependencies. - v14.5 was for AsyncLocalStorage - v14.6 brings a V8 with spport for private methods syntax, FinalizationRegistry (used by pino@8) - v14.8 brings AsyncResource.bind - v14.17 brings AbortController, AbortSignal.reason (used by readable-stream@4, glob@10, etc.) Closes: elastic#2760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps our min Node.js from v14.5 to v14.17; and bumps a number
of dependencies.
Closes: #2760