tests: fix test failure due to os.freemem() behaviour change in node v18#2530
Merged
Conversation
Recent node v18 nightly builds changed the behaviour of os.freemem() on Linux to report "MemAvailable" from /proc/meminfo rather than "MemFree". This broke our tests.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
astorm
approved these changes
Jan 15, 2022
trentm
added a commit
that referenced
this pull request
Jan 20, 2022
…v17.4.0 The update to libuv 1.43.0 changed the behaviour of os.freemem() on Linux to report "MemAvailable" from /proc/meminfo rather than "MemFree". Refs: #2530
astorm
pushed a commit
that referenced
this pull request
Feb 4, 2022
…v18 (#2530) Recent node v18 nightly builds changed the behaviour of os.freemem() on Linux to report "MemAvailable" from /proc/meminfo rather than "MemFree". This broke our tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent node v18 nightly builds changed the behaviour of os.freemem()
on Linux to report "MemAvailable" from /proc/meminfo rather than
"MemFree". This broke our tests.
The nightly "edge" tests started failing ~6-7 days ago with:
The breakage started in node nightly build "v18.0.0-nightly20220107b6b6510187".
The culprit node change was nodejs/node#41398, which upgrades libuv, which brought in a change to
os.freemem()on Linux: libuv/libuv#3351This broke an assumption in our tests.