Skip to content

Commit

Permalink
chore: remove nyc package (#4120)
Browse files Browse the repository at this point in the history
  • Loading branch information
david-luna committed Jul 9, 2024
1 parent ebe2cd1 commit 0a94abf
Show file tree
Hide file tree
Showing 11 changed files with 25 additions and 2,201 deletions.
8 changes: 1 addition & 7 deletions .ci/scripts/docker-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,8 @@ node --version
npm --version
npm_ci

# Attempt to provide junit-formatted test results, for Jenkins' "Test Results"
# and other features like flaky-test reporting.
if [[ -n ${TAV} ]]; then
npm run test:tav
# Currently the TAV tests do not support TAP or junit-formatted output.
else
rm -rf ./test_output
mkdir ./test_output
nyc node test/test.js -o ./test_output
ls test_output/*.tap | while read f; do cat $f | ./node_modules/.bin/tap-junit > $f.junit.xml; done
node test/test.js
fi
9 changes: 0 additions & 9 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,6 @@ jobs:
- run: npm ls --all || true
- name: npm test
run: npm test
- uses: inception-health/otel-upload-test-artifact-action@v1
if: always()
continue-on-error: true
with:
jobName: "test-vers (${{ matrix.node }})"
stepName: "npm test"
path: "test_output/*.junit.xml"
type: "junit"
githubToken: ${{ secrets.GITHUB_TOKEN }}

test-windows:
runs-on: windows-latest
Expand Down
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
/test-suite-output.tap

# Folders to ignore
/.nyc_output
/test_output
/build
node_modules
/test/benchmarks/.tmp
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ fmt:
npm run lint:fix

# Prerequisite: Docker server is running.
# See TESTING.md for more details on tests, TAV tests, coverage, benchmarks.
# See TESTING.md for more details on tests, TAV tests, benchmarks.
.PHONY: test
test:
npm run test
1 change: 0 additions & 1 deletion eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ module.exports = [
'*.example.js', // a pattern for uncommited local dev files to avoid linting
'*.example.mjs', // a pattern for uncommited local dev files to avoid linting

'test_output/**',
'tmp/**',
'.nyc_output/**',
'build/**',
Expand Down
3 changes: 0 additions & 3 deletions examples/nextjs/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
/.pnp
.pnp.js

# testing
/coverage

# next.js
/.next/
/out/
Expand Down
3 changes: 1 addition & 2 deletions lib/activation-method.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ const CONTAINS_R_ELASTIC_APM_NODE_START =
*
* @param {Error} startStack - An Error object with a captured stack trace.
* The `stackTraceLimit` for the stack should be at least 15 -- higher
* that the default of 10. Using `nyc` for coverage testing adds at least
* one stack frame.
* that the default of 10.
* @returns {string} one of the following values:
* - "unknown"
* - "require":
Expand Down
Loading

0 comments on commit 0a94abf

Please sign in to comment.