Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

(#628) Added io.netty.allocator.numDirectArenas=0 flag to jvm.options #631

Closed
wants to merge 4 commits into from

Conversation

andrx
Copy link

@andrx andrx commented Nov 14, 2019

(#628) Added io.netty.allocator.numDirectArenas=0 flag to overcome RAM issues on ES >= 7.4.0

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt
Copy link
Member

jmlrt commented Nov 21, 2019

jenkins test this please

andrx and others added 2 commits November 21, 2019 10:52
updates for latest ansible versions

Co-Authored-By: Julien Mailleret <jmlrt@users.noreply.github.com>
@jmlrt
Copy link
Member

jmlrt commented Nov 21, 2019

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt
Copy link
Member

jmlrt commented Nov 21, 2019

@andrx I was ready to merge your PR but it seems that jvm options will change in next Elasticsearch release elastic/elasticsearch#48252

@andrx
Copy link
Author

andrx commented Nov 21, 2019

@jmlrt hey, no problem... great to hear.
so, will you update the template accordingly or I misunderstood how it's going to work

@jmlrt
Copy link
Member

jmlrt commented Nov 22, 2019

Yeah I'll need to check in details what is required

If there is just things to change in the current jvm.options template, maybe I'll be able to post changes required to this PR so you can include them before merging.

If a different solution is required (maybe use default jvm.options file from Elasticsearch package and allow to fully overwrite it only if some variables are provided to ansible) I'll create a new PR and close this one.

Anyway thank you for your work on this PR 👍

@andrx
Copy link
Author

andrx commented Nov 22, 2019

Sure, great that it will be sorted with ES 7.5

@jmlrt jmlrt mentioned this pull request Nov 26, 2019
@jmlrt
Copy link
Member

jmlrt commented Dec 5, 2019

@andrx, I was finally able to merge #637 which handle jvm options. I'm closing your PR. Thank you for your work here👍

@jmlrt jmlrt closed this Dec 5, 2019
@andrx
Copy link
Author

andrx commented Dec 5, 2019

@jmlrt just curious when do you plan to release those. at the moment i temporarily pointed it to master but would like to set a specific version.
thanks in advance

@jmlrt
Copy link
Member

jmlrt commented Dec 5, 2019

We were waiting #637 merge to create 7.5.0 release and may still have a couple of small pr to pass, so the release should come in the beginning of next week.

@andrx
Copy link
Author

andrx commented Dec 5, 2019

got it. thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants