Add tests during Django Tutorial Part 5

Author: elandt

mysite/polls/models.py

@@ -20,7 +20,8 @@ def __str__(self):
         return self.question_text
 
     def was_published_recently(self):
-        return self.pub_date >= timezone.now() - datetime.timedelta(days=1)
+        now = timezone.now()
+        return now - datetime.timedelta(days=1) <= self.pub_date <= now
 
 
 class Choice(models.Model):

mysite/polls/tests.py

@@ -1,3 +1,142 @@
+import datetime
+
 from django.test import TestCase
+from django.utils import timezone
+from django.urls import reverse
+
+from .models import Question
 
 # Create your tests here.
+# Rules-of-thumb for tests:
+# * have a separate TestClass for each model or view
+# * have a separate test method for each set of conditions you want to test
+# * use test method names that describe their function
+
+
+def create_question(question_text, days):
+    """
+    Create a question with the given 'question_text' and published the
+    given number of 'days' offset to now (negative for questions published
+    in the past, positive for questions that have yet to be published).
+    """
+    time = timezone.now() + datetime.timedelta(days=days)
+    return Question.objects.create(question_text=question_text, pub_date=time)
+
+
+class QuestionModelTests(TestCase):
+    # Django auto-detects test methods by looking
+    # for methods starting with "test"
+    def test_was_published_recently_with_future_question(self):
+        """
+        was_published_recently() returns False for questions whose pub_date
+        is in the future.
+        """
+        time = timezone.now() + datetime.timedelta(days=30)
+        future_question = Question(pub_date=time)
+
+        self.assertIs(future_question.was_published_recently(), False)
+
+    def test_was_published_recently_with_old_question(self):
+        """
+        was_published_recently() returns False for questions whose pub_date
+        is older than 1 day.
+        """
+        time = timezone.now() - datetime.timedelta(days=1, seconds=1)
+        old_question = Question(pub_date=time)
+
+        self.assertIs(old_question.was_published_recently(), False)
+
+    def test_was_published_recently_with_recent_question(self):
+        """
+        was_published_recently() returns True for questions whose pub_date
+        is within the last day.
+        """
+        time = timezone.now() - datetime.timedelta(hours=23, minutes=59, seconds=59)
+        recent_question = Question(pub_date=time)
+
+        self.assertIs(recent_question.was_published_recently(), True)
+
+
+class QuestionIndexViewTests(TestCase):
+    def test_no_questions(self):
+        """
+        If no questions exist, an appropriate message is displayed.
+        """
+        expected_result = "No polls are available."
+        response = self.client.get(reverse("polls:index"))
+        self.assertEqual(response.status_code, 200)
+        self.assertContains(response, expected_result)
+        self.assertQuerysetEqual(response.context["latest_question_list"], [])
+
+    def test_past_question(self):
+        """
+        Questions with a pub_date in the past are displayed on the
+        index page.
+        """
+        expected_result = ["<Question: Past Question.>"]
+        create_question(question_text="Past Question.", days=-30)
+        response = self.client.get(reverse("polls:index"))
+        self.assertQuerysetEqual(
+            response.context["latest_question_list"], expected_result
+        )
+
+    def test_future_question(self):
+        """
+        Questions with a pub_date in the future aren't displayed on
+        the index page.
+        """
+        expected_result = "No polls are available."
+        create_question(question_text="Future Question.", days=30)
+        response = self.client.get(reverse("polls:index"))
+        self.assertContains(response, expected_result)
+        self.assertQuerysetEqual(response.context["latest_question_list"], [])
+
+    def test_future_question_and_past_question(self):
+        """
+        Even if both past and future questions exist, only past questions
+        are displayed.
+        """
+        expected_result = ["<Question: Past Question.>"]
+        create_question(question_text="Past Question.", days=-30)
+        create_question(question_text="Future Question.", days=30)
+        response = self.client.get(reverse("polls:index"))
+        self.assertQuerysetEqual(
+            response.context["latest_question_list"], expected_result
+        )
+
+    def test_two_past_questions(self):
+        """
+        The questions index page may display multiple questions.
+        """
+        expected_result = [
+            "<Question: Past Question 2.>",
+            "<Question: Past Question 1.>",
+        ]
+        create_question(question_text="Past Question 1.", days=-30)
+        create_question(question_text="Past Question 2.", days=-5)
+        response = self.client.get(reverse("polls:index"))
+        self.assertQuerysetEqual(
+            response.context["latest_question_list"], expected_result
+        )
+
+
+class QuestionDetailViewTests(TestCase):
+    def test_future_question(self):
+        """
+        The detail view of a question with a pub_date in the future
+        returns a 404 not found.
+        """
+        future_question = create_question(question_text="Future Question.", days=5)
+        url = reverse("polls:detail", args=(future_question.id))
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 404)
+
+    def test_past_question(self):
+        """
+        The detail view of a question with a pub_date in the past
+        displays the question's text.
+        """
+        past_question = create_question(question_text="Past Question.", days=-5)
+        url = reverse("polls:detail", args=(past_question.id))
+        response = self.client.get(url)
+        self.assertContains(response, past_question.question_text)

mysite/polls/views.py

@@ -5,6 +5,7 @@
 from django.http import HttpResponseRedirect
 from django.urls import reverse
 from django.views import generic
+from django.utils import timezone
 
 from .models import Choice, Question
 
@@ -18,8 +19,16 @@ class IndexView(generic.ListView):
     context_object_name = "latest_question_list"
 
     def get_queryset(self):
-        """Return the last five pulished questions."""
-        return Question.objects.order_by("-pub_date")[:5]
+        """
+        Return the last five pulished questions (not
+        including those set to be published in the
+        future).
+        """
+        now = timezone.now()
+        order = "-pub_date"
+        # __lte filters for pub_date less than or equal
+        # to the provided value
+        return Question.objects.filter(pub_date__lte=now).order_by(order)[:5]
 
 
 class DetailView(generic.DetailView):
@@ -28,6 +37,12 @@ class DetailView(generic.DetailView):
     # generic, default is <app name>/<model name>_detail.html
     template_name = "polls/detail.html"
 
+    def get_queryset(self):
+        """
+        Excludes any questions that aren't published yet.
+        """
+        return Question.objects.filter(pub_date__lte=timezone.now())
+
 
 class ResultsView(generic.DetailView):
     model = Question