Skip to content

Update aws-sdk-go-v2 dependencies and mockery comments #8347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025

Conversation

naclonts
Copy link
Member

@naclonts naclonts commented Apr 9, 2025

Description

Ran make build to update the patch versions of some aws-sdk-go-v2 dependencies.

This also updated the mock files' "mockery version" comment, since those files hadn't been regenerated since the last mockery update.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@naclonts naclonts added skip-release-notes Causes PR not to show in release notes dependencies Pull requests that update a dependency file labels Apr 9, 2025
@naclonts naclonts requested a review from cheeseandcereal April 9, 2025 21:28
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello naclonts 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@ankurp-rafay
Copy link

Hey @naclonts , do you know when eksctl will add support for AWS community add-ons? Will this update include that support, or is it already available in eksctl? I couldn’t find it.

Copy link
Member

@cheeseandcereal cheeseandcereal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@naclonts naclonts merged commit a235ee1 into eksctl-io:main Apr 10, 2025
9 checks passed
@naclonts
Copy link
Member Author

Hey @naclonts , do you know when eksctl will add support for AWS community add-ons? Will this update include that support, or is it already available in eksctl? I couldn’t find it.

Hey @ankurp-rafay, eksctl does support AWS community add-ons today. For example, kube-state-metrics can be installed with:

eksctl create addon --cluster {cluster} --name kube-state-metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants