Skip to content

Fully remove intermediate eksctl build image #8341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

Fully remove intermediate eksctl build image #8341

merged 1 commit into from
Apr 2, 2025

Conversation

cheeseandcereal
Copy link
Member

@cheeseandcereal cheeseandcereal commented Apr 1, 2025 •
edited
Loading

Description

This PR fully removes the eksctl build image. This is a continuation of the work from #8242

This also fixes the docker build, and updates dependencies appropriately.

Related with https://github.com/eksctl-io/eksctl-ci/pull/154

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cheeseandcereal cheeseandcereal added skip-release-notes Causes PR not to show in release notes dependencies Pull requests that update a dependency file labels Apr 1, 2025
@cheeseandcereal cheeseandcereal changed the title Update package dependencies Fully remove intermediate eksctl build image Apr 2, 2025
@cheeseandcereal cheeseandcereal marked this pull request as draft April 2, 2025 01:24
@cheeseandcereal cheeseandcereal added area/build-and-release area/tech-debt Leftover improvements in code, testing and building and removed skip-release-notes Causes PR not to show in release notes labels Apr 2, 2025
@cheeseandcereal cheeseandcereal marked this pull request as ready for review April 2, 2025 07:29
@cheeseandcereal cheeseandcereal requested a review from a-hilaly April 2, 2025 07:29
@cheeseandcereal cheeseandcereal merged commit af0074e into main Apr 2, 2025
8 checks passed
@cheeseandcereal cheeseandcereal deleted the update-dependencies branch April 2, 2025 18:25
This was referenced Apr 2, 2025
Merged
Open
@naclonts naclonts mentioned this pull request Apr 9, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavodiaz7722 gustavodiaz7722 gustavodiaz7722 approved these changes

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

Assignees
No one assigned
Labels
area/build-and-release area/tech-debt Leftover improvements in code, testing and building dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheeseandcereal @gustavodiaz7722