Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto mode creation when no permissions boundary is set #8312

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

cheeseandcereal
Copy link
Member

Description

After merging #8307, creation of clusters with auto mode without an explicit permissions boundary broke because they were getting set with the 'zero' arn value of arn:::::, this fixes that bug.

Tested by manually creating clusters before and after.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cheeseandcereal cheeseandcereal added kind/bug skip-release-notes Causes PR not to show in release notes labels Mar 23, 2025
@cheeseandcereal cheeseandcereal requested a review from dims March 23, 2025 00:17
Copy link
Contributor

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cheeseandcereal cheeseandcereal merged commit 47dc7f2 into main Mar 23, 2025
11 checks passed
@cheeseandcereal cheeseandcereal deleted the fix-auto-mode-permissions-boundary branch March 23, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants