-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proposal requirements and template #3136
Conversation
let's take the rebase action for a test drive |
/rebase |
b08ce74
to
a0095a1
Compare
oh snap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -13,3 +13,4 @@ k8s.io/code-generator/cmd/deepcopy-gen | |||
k8s.io/code-generator/cmd/defaulter-gen | |||
k8s.io/code-generator/cmd/informer-gen | |||
k8s.io/code-generator/cmd/lister-gen | |||
sigs.k8s.io/mdtoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably not ideal here since it ends up in the build image but i don't think we have a better place to put it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
a0095a1
to
c3f68c7
Compare
c3f68c7
to
dcda497
Compare
Description
docs/proposal-000-template.md
(name up for debate).This is all up for debate, please disagree with any headings or ask for more. This is a mashup of Kep, Mark E's ideas and mine. Hopefully we can settle on a standard which will work for us.
No rush, merged by EOD 29th would be neat if possible.
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
) and kind (e.g.kind/improvement
)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯