Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal requirements and template #3136

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

Callisto13
Copy link
Contributor

@Callisto13 Callisto13 commented Jan 22, 2021

Description

  • Created proposal template at docs/proposal-000-template.md (name up for debate).
  • Updated Proposal section in Contributing doc
  • Added k8s' toc generator to build deps for easy tocing (Do we actually add stuff like this to build deps tho? it's not technically required, just handy. LMK before I rebuild any images.)

This is all up for debate, please disagree with any headings or ask for more. This is a mashup of Kep, Mark E's ideas and mine. Hopefully we can settle on a standard which will work for us.

No rush, merged by EOD 29th would be neat if possible.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Callisto13 Callisto13 added area/docs skip-release-notes Causes PR not to show in release notes labels Jan 22, 2021
@Callisto13
Copy link
Contributor Author

let's take the rebase action for a test drive

@Callisto13
Copy link
Contributor Author

/rebase

@Callisto13
Copy link
Contributor Author

oh snap

Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -13,3 +13,4 @@ k8s.io/code-generator/cmd/deepcopy-gen
k8s.io/code-generator/cmd/defaulter-gen
k8s.io/code-generator/cmd/informer-gen
k8s.io/code-generator/cmd/lister-gen
sigs.k8s.io/mdtoc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not ideal here since it ends up in the build image but i don't think we have a better place to put it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay 😞

Copy link
Contributor

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Callisto13 Callisto13 merged commit f3fe3a3 into eksctl-io:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants