Add proposal requirements and template #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callisto13
added
area/docs
skip-release-notes
|
let's take the rebase action for a test drive |
|
/rebase |
github-actions
bot
force-pushed
the
proposal-template
branch
from
b08ce74 to
a0095a1
Compare
|
oh snap |
michaelbeaumont
approved these changes
Jan 28, 2021
| @@ -13,3 +13,4 @@ k8s.io/code-generator/cmd/deepcopy-gen | |||
| k8s.io/code-generator/cmd/defaulter-gen | |||
| k8s.io/code-generator/cmd/informer-gen | |||
| k8s.io/code-generator/cmd/lister-gen | |||
| sigs.k8s.io/mdtoc | |||
There was a problem hiding this comment.
probably not ideal here since it ends up in the build image but i don't think we have a better place to put it
Callisto13
force-pushed
the
proposal-template
branch
from
a0095a1 to
c3f68c7
Compare
Callisto13
force-pushed
the
proposal-template
branch
from
c3f68c7 to
dcda497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
docs/proposal-000-template.md(name up for debate).This is all up for debate, please disagree with any headings or ask for more. This is a mashup of Kep, Mark E's ideas and mine. Hopefully we can settle on a standard which will work for us.
No rush, merged by EOD 29th would be neat if possible.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯