[0022] Rename dependencies attrs to be more intuitive #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
changed the title
| # CMake is used at buildtime, to produce code for the host platform | ||
| buildtimeDeps = [ cmake ]; | ||
| commands = [ cmake ]; |
There was a problem hiding this comment.
Hmm, a static binary could have build time deps which are libraries
Contributor
Author
There was a problem hiding this comment.
Do you have an example?
Pretty sure the .a's are still targeting hostTarget which would be a buildInputs/library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nativeBuildInputsandbuildInputsare not intuitive.buildInputsmade sense as a "nix build" needed "these things" for a build. However,nativeBuildInputswas added later to differentiate what "needs to be ran at build time, versus what was needed at run time", but the names aren't clear unless you have spelunked in stdenv's nebulous implementation.Rendered: https://github.com/ekala-project/eeps/blob/rename-cross/eeps/0022-rename-cross-attrs.md