Move highstock to app

Author: mohammad-deriv

src/javascript/_common/common_functions.js

@@ -82,13 +82,6 @@ const getSetElementValue = (element, text, type) => { // eslint-disable-line con
     }
 };
 
-const requireHighstock = callback => (
-    require.ensure([], (require) => {
-        const Highstock = require('highstock-release');
-        return callback(Highstock);
-    }, 'highstock')
-);
-
 /*
  * @param  {String}  id_selector   the selector for the element
  * @param  {Element} parent        optional selector to use for parent, defaults to document
@@ -112,7 +105,6 @@ module.exports = {
     checkInput,
     dateValueChanged,
     selectorExists,
-    requireHighstock,
     getElementById,
     getVisibleElement,
     elementTextContent: (element, text) => getSetElementValue(element, text, 'textContent'),

src/javascript/app/pages/trade/charts/digit_info.js

@@ -1,8 +1,8 @@
-const CreateDropdown     = require('@binary-com/binary-style').selectDropdown;
-const Symbols      = require('../symbols');
-const BinarySocket = require('../../../base/socket');
-const getHighstock = require('../../../../_common/common_functions').requireHighstock;
-const localize     = require('../../../../_common/localize').localize;
+const CreateDropdown = require('@binary-com/binary-style').selectDropdown;
+const getHighstock   = require('../common').requireHighstock;
+const Symbols        = require('../symbols');
+const BinarySocket   = require('../../../base/socket');
+const localize       = require('../../../../_common/localize').localize;
 
 const DigitInfo = (() => {
     let spots          = [];

src/javascript/app/pages/trade/charts/highchart.js

@@ -1,4 +1,5 @@
 const HighchartUI      = require('./highchart.ui');
+const getHighstock     = require('../common').requireHighstock;
 const MBContract       = require('../../mb_trade/mb_contract');
 const MBDefaults       = require('../../mb_trade/mb_defaults');
 const Defaults         = require('../../trade/defaults');
@@ -8,7 +9,6 @@ const ViewPopupUI      = require('../../user/view_popup/view_popup.ui');
 const isJPClient       = require('../../../base/client').isJPClient;
 const BinarySocket     = require('../../../base/socket');
 const addComma         = require('../../../common/currency').addComma;
-const getHighstock     = require('../../../../_common/common_functions').requireHighstock;
 const localize         = require('../../../../_common/localize').localize;
 const State            = require('../../../../_common/storage').State;
 const getPropertyValue = require('../../../../_common/utility').getPropertyValue;

src/javascript/app/pages/trade/common.js

@@ -376,6 +376,13 @@ const commonTrading = (() => {
         return true;
     };
 
+    const requireHighstock = callback => (
+        require.ensure([], (require) => {
+            const Highstock = require('highstock-release');
+            return callback(Highstock);
+        }, 'highstock')
+    );
+
     return {
         getFormNameBarrierCategory,
         contractTypeDisplayMapping,
@@ -395,6 +402,7 @@ const commonTrading = (() => {
         displayContractForms,
         displayMarkets,
         timeIsValid,
+        requireHighstock,
         showPriceOverlay: () => { showHideOverlay('loading_container2', 'block'); },
         hidePriceOverlay: () => { showHideOverlay('loading_container2', 'none'); },
         hideFormOverlay : () => { showHideOverlay('loading_container3', 'none'); },

src/javascript/app/pages/trade/tick_trade.js

@@ -1,4 +1,5 @@
 const moment               = require('moment');
+const requireHighstock     = require('./common').requireHighstock;
 const Tick                 = require('./tick');
 const updatePurchaseStatus = require('./update_values').updatePurchaseStatus;
 const ViewPopupUI          = require('../user/view_popup/view_popup.ui');
@@ -66,7 +67,7 @@ const TickDisplay = (() => {
         const end_time = parseInt(data.contract_start) + parseInt((number_of_ticks + 2) * 5);
 
         setXIndicators();
-        CommonFunctions.requireHighstock((Highstock) => {
+        requireHighstock((Highstock) => {
             Highcharts = Highstock;
             initializeChart({
                 minimize,