Skip to content

Commit d48b635

Browse files
committed
Use Yaml indentation hints to avoid otherwise needless parentheses
Signed-off-by: beorn7 <beorn@grafana.com>
1 parent 6909147 commit d48b635

File tree

1 file changed

+20
-30
lines changed

1 file changed

+20
-30
lines changed

content/docs/practices/rules.md

Lines changed: 20 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -64,31 +64,25 @@ Calculating a request failure ratio and aggregating up to the job-level failure
6464
expr: rate(request_failures_total{job="myjob"}[5m])
6565
6666
- record: instance_path:request_failures_per_requests:ratio_rate5m
67-
expr: |
68-
(
69-
instance_path:request_failures:rate5m{job="myjob"}
70-
/
71-
instance_path:requests:rate5m{job="myjob"}
72-
)
67+
expr: |2
68+
instance_path:request_failures:rate5m{job="myjob"}
69+
/
70+
instance_path:requests:rate5m{job="myjob"}
7371
7472
# Aggregate up numerator and denominator, then divide to get path-level ratio.
7573
- record: path:request_failures_per_requests:ratio_rate5m
76-
expr: |
77-
(
78-
sum without (instance)(instance_path:request_failures:rate5m{job="myjob"})
79-
/
80-
sum without (instance)(instance_path:requests:rate5m{job="myjob"})
81-
)
74+
expr: |2
75+
sum without (instance)(instance_path:request_failures:rate5m{job="myjob"})
76+
/
77+
sum without (instance)(instance_path:requests:rate5m{job="myjob"})
8278
8379
# No labels left from instrumentation or distinguishing instances,
8480
# so we use 'job' as the level.
8581
- record: job:request_failures_per_requests:ratio_rate5m
86-
expr: |
87-
(
88-
sum without (instance, path)(instance_path:request_failures:rate5m{job="myjob"})
89-
/
90-
sum without (instance, path)(instance_path:requests:rate5m{job="myjob"})
91-
)
82+
expr: |2
83+
sum without (instance, path)(instance_path:request_failures:rate5m{job="myjob"})
84+
/
85+
sum without (instance, path)(instance_path:requests:rate5m{job="myjob"})
9286
```
9387

9488

@@ -102,21 +96,17 @@ Calculating average latency over a time period from a Summary:
10296
expr: rate(request_latency_seconds_sum{job="myjob"}[5m])
10397
10498
- record: instance_path:request_latency_seconds:mean5m
105-
expr: |
106-
(
107-
instance_path:request_latency_seconds_sum:rate5m{job="myjob"}
108-
/
109-
instance_path:request_latency_seconds_count:rate5m{job="myjob"}
110-
)
99+
expr: |2
100+
instance_path:request_latency_seconds_sum:rate5m{job="myjob"}
101+
/
102+
instance_path:request_latency_seconds_count:rate5m{job="myjob"}
111103
112104
# Aggregate up numerator and denominator, then divide.
113105
- record: path:request_latency_seconds:mean5m
114-
expr: |
115-
(
116-
sum without (instance)(instance_path:request_latency_seconds_sum:rate5m{job="myjob"})
117-
/
118-
sum without (instance)(instance_path:request_latency_seconds_count:rate5m{job="myjob"})
119-
)
106+
expr: |2
107+
sum without (instance)(instance_path:request_latency_seconds_sum:rate5m{job="myjob"})
108+
/
109+
sum without (instance)(instance_path:request_latency_seconds_count:rate5m{job="myjob"})
120110
```
121111

122112
Calculating the average query rate across instances and paths is done using the

0 commit comments

Comments
 (0)