Skip to content

Commit 4fce1f3

Browse files
committed
Fix I2C config parameter interpretation
The current implementation pulls bytes out of the sysex buffer, regardless of whether or not the user specified such bytes.
1 parent 78d340f commit 4fce1f3

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

examples/StandardFirmata/StandardFirmata.ino

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
586586
case I2C_CONFIG:
587587
delayTime = (argv[0] + (argv[1] << 7));
588588

589-
if (delayTime > 0) {
589+
if (argc > 1 && delayTime > 0) {
590590
i2cReadDelayTime = delayTime;
591591
}
592592

examples/StandardFirmataBLE/StandardFirmataBLE.ino

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
603603
case I2C_CONFIG:
604604
delayTime = (argv[0] + (argv[1] << 7));
605605

606-
if (delayTime > 0) {
606+
if (argc > 1 && delayTime > 0) {
607607
i2cReadDelayTime = delayTime;
608608
}
609609

examples/StandardFirmataChipKIT/StandardFirmataChipKIT.ino

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
588588
case I2C_CONFIG:
589589
delayTime = (argv[0] + (argv[1] << 7));
590590

591-
if (delayTime > 0) {
591+
if (argc > 1 && delayTime > 0) {
592592
i2cReadDelayTime = delayTime;
593593
}
594594

examples/StandardFirmataEthernet/StandardFirmataEthernet.ino

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
666666
case I2C_CONFIG:
667667
delayTime = (argv[0] + (argv[1] << 7));
668668

669-
if (delayTime > 0) {
669+
if (argc > 1 && delayTime > 0) {
670670
i2cReadDelayTime = delayTime;
671671
}
672672

examples/StandardFirmataPlus/StandardFirmataPlus.ino

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
611611
case I2C_CONFIG:
612612
delayTime = (argv[0] + (argv[1] << 7));
613613

614-
if (delayTime > 0) {
614+
if (argc > 1 && delayTime > 0) {
615615
i2cReadDelayTime = delayTime;
616616
}
617617

examples/StandardFirmataWiFi/StandardFirmataWiFi.ino

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -675,7 +675,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
675675
case I2C_CONFIG:
676676
delayTime = (argv[0] + (argv[1] << 7));
677677

678-
if (delayTime > 0) {
678+
if (argc > 1 && delayTime > 0) {
679679
i2cReadDelayTime = delayTime;
680680
}
681681

0 commit comments

Comments
 (0)