Do not place newline after last/single error #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not place a newline after the last error message. Also works if there is only one error message. Signed-off-by: Léon Melis <leon@leonmelis.nl>
|
Please check the tests https://github.com/egulias/EmailValidator/actions/runs/13290888207/job/38343362212?pr=406 |
|
And thanks for the PR! |
|
I used the GitHub in-browser editing mode to create this quick 'n dirty PR, I didn't think of the tests, apologies! It looks like I just need to adjust the expected outcome of the test. But to do so I guess I'll have to do a 'real' PR flow (fork, clone, edit, run tests, commit, PR), which probably means we'll have to close this PR and then open a new one. Not sure when I'll have time for that though. If you don't want to wait you can also just close this PR and use my code in your own commit. I don't need the credit or recognition for it, I just wanted to help :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not place a newline after the last error message. Also works if there is only one error message.