-
-
Notifications
You must be signed in to change notification settings - Fork 225
ci: Add tests for PHP 8.4 #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.x
Are you sure you want to change the base?
Conversation
|
vimeo/psalm#10928 (comment) will be available "the next week." (I can't unapprove now) |
|
Hi @Chris53897 thanks for your PR. I have fixed the checks so please update with the latest code to have the checks pass. |
|
Looks like at least psalm version needs to be bumped up. |
|
i rebased now. Yes, we still ned to wait for vimeo |
|
Thanks! Will wait for them then. |
|
This will look awful... but I can't find where to re-run the checks! |
|
You can just close and reopen this PR. CI will run again
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
|
"Just" 200 Errors from upgrading psalm. |
|
I guess we should fix them? I agree with |
|
@egulias Should i add the Override Attribute? |
No description provided.