Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eggolib makes Minecraft commands unable to select display entities with entity tags #52

Open
Sterrezo opened this issue Jun 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Sterrezo
Copy link

Using tags in selectors when executing commands targeting Block Displays doesn't work with latest version of Eggolib.

  • Summon a block display with /summon minecraft:block_display ~ ~ ~ {Tags:["mytag"]}
  • Confirm the block display has a tag with /data get entity @e[type=minecraft:block_display,limit=1]
  • Select the block display with commands /kill @e[type=minecraft:block_display,tag=mytag]
  • The /kill command will fail, not finding a valid entity.

I've tested on a fresh instance with no other mods (other than Origins) and can confirm this occurs only with Eggolib installed. Version v1.9.0 of Eggolib and unmodded Minecraft work as intended.

I haven't tested all entities, but this doesn't happen with passive mobs (pig, chicken). I found this while updating my Origin that relies on commands and Block Displays.

@Sterrezo Sterrezo changed the title Eggolib causes Minecraft commands to not work properly with entity tags Eggolib makes Minecraft commands unable to select Block Displays with entity tags Jun 15, 2024
@Sterrezo
Copy link
Author

I completely missed #48 before posting...
It's definitely related, but Block Displays slipped through the fix.

I also tested Item Displays and Text Displays, selecting them using tags is also broken with Eggolib.

@Sterrezo Sterrezo changed the title Eggolib makes Minecraft commands unable to select Block Displays with entity tags Eggolib makes Minecraft commands unable to select display entities with entity tags Jun 15, 2024
@eggohito eggohito added the bug Something isn't working label Jun 17, 2024
@eggohito
Copy link
Owner

It seems like this issue is not at all dependent on the entity's type, but more so on how and when the commands are executed (apace100/origins-fabric#757 (comment) for an explanation.) I'll fix this (again) soon-ish 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants