xxd -n option

[fvalasiad]

xxd fails because it does not recognize -n schema.

Failing to find any info on the web or manpage regarding that option, is it platform-specific?

I'd recommend instead letting it just print the values and then simply doing:

arr = { #include "schema.h" }

[zvr]

I've been using xxd that comes with vim,
I don't think xxd is specified in POSIX, so relying on any specific behavior will be problematic, anyway.

[fvalasiad]

@zvr Should I look for alternative POSIX defined ways to achieve the same result? Or even code it, it's relatively simple.

[zvr]

I don't think it's worth it. This is only used when the schema changes, which should be rare.
We just have to make sure that the generated .h file is included in the release tarball.

[fvalasiad]

@zvr Do I fix the above PR then and make sure the generated schema.h is included in the tarball?

[zvr]

Yes, please -- something like #213.
Submit a new PR and close the old one, there will be no relation in the code.

[fvalasiad]

@zvr I am a little confused, what is the goal of the PR? The problem of schema not being included in the tarball was already somehow dealt with in #213. In the PR it can be seen that I also include $SCHEMA in the tarball.

If we are not tackling the -n option issue with #215, what do we do instead?

[zvr]

The schema is included in the tarball.
The new PR should also add the generated schema.c in the tarball, so that people can compile the software without need to use xxd.

[fvalasiad]

Well looking around out of curiosity. vim/vim@83e1180

It's a fairly recent addition, so my current OS based off of ubuntu jammy 22.04 does not include it. Debian 12 should have it though, it's only LTS versions that are impacted by this.