refactor: add prehandler for every selector of visitor

Author: edvardchen

lib/rules/no-literal-string.js

@@ -95,6 +95,10 @@ module.exports = {
       return temp;
     }
 
+    function isString(node) {
+      return typeof node.value === 'string';
+    }
+
     const scriptVisitor = {
       //
       // ─── EXPORT AND IMPORT ───────────────────────────────────────────
@@ -162,7 +166,6 @@ module.exports = {
       },
 
       'Property > Literal'(node) {
-        if (visited.includes(node)) return;
         const { parent } = node;
         // if node is key of property, skip
         if (parent.key === node) visited.push(node);
@@ -174,14 +177,11 @@ module.exports = {
       },
 
       'CallExpression Literal'(node) {
-        if (visited.includes(node)) return;
         const parent = getNearestAncestor(node, 'CallExpression');
         if (isValidFunctionCall(parent)) visited.push(node);
       },
 
       'Literal:exit'(node) {
-        if (visited.includes(node)) return;
-
         if (typeof node.value === 'string') {
           const trimed = node.value.trim();
           if (!trimed) return;
@@ -196,6 +196,23 @@ module.exports = {
         }
       }
     };
+
+    function wrapVisitor() {
+      Object.keys(scriptVisitor).forEach(key => {
+        const old = scriptVisitor[key];
+        scriptVisitor[key] = node => {
+          // make sure node is string literal
+          if (!isString(node)) return;
+
+          // visited and passed linting
+          if (visited.includes(node)) return;
+          old(node);
+        };
+      });
+    }
+
+    wrapVisitor();
+
     return (
       (parserServices.defineTemplateBodyVisitor &&
         parserServices.defineTemplateBodyVisitor(

tests/lib/rules/no-literal-string.js

@@ -35,6 +35,7 @@ ruleTester.run('no-literal-string', rule, {
     { code: 'require("hello");' },
     { code: 'const a = require(["hello"]);' },
     { code: 'const a = require(["hel" + "lo"]);' },
+    { code: 'const a = 1;' },
     { code: 'i18n("hello");' },
     { code: 'dispatch("hello");' },
     { code: 'store.dispatch("hello");' },