Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using HTTPoison.Base results in compiler warnings in 1.4 #207

Closed
sotojuan opened this issue Jan 5, 2017 · 4 comments
Closed

Using HTTPoison.Base results in compiler warnings in 1.4 #207

sotojuan opened this issue Jan 5, 2017 · 4 comments

Comments

@sotojuan
Copy link

sotojuan commented Jan 5, 2017

Essentially, the warnings are like this one:

making private functions (process_request_headers/1 in this case) overridable is deprecated

From Slack:

Probably due to https://github.com/edgurgel/httpoison/blob/master/lib/httpoison/base.ex#L349
should probably be Module.definitions_in __MODULE__, :def
@aquarhead
Copy link

Fixed by #201 ?

@sotojuan
Copy link
Author

sotojuan commented Jan 6, 2017

Will have to try from master, thanks.

@sotojuan
Copy link
Author

sotojuan commented Jan 6, 2017

Yup, works on master. Thanks. @edgurgel can we have a release?

@sotojuan sotojuan closed this as completed Jan 6, 2017
@edgurgel
Copy link
Owner

edgurgel commented Jan 8, 2017

0.11.0 is out! Hopefully we can get 1.0 out soon after this release! Thanks!

https://github.com/edgurgel/httpoison/releases/tag/v0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@edgurgel @aquarhead @sotojuan