Run tests in CI without secret credentials #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store them in the repo (at `repo-root/web_monitoring/tests/fixtures` instead of `~/.cache/web-monitoring-processing/tests`) and only require environment variables with staging credentials to be present if we are fetching *new* never-before-seen fixtures. Someone without credentials will now be able to run these tests.
We don't actually use this, and it requires an environment variable most people won't have. This prevents people from running tests locally and it prevents CI from being able to run tests on forks. Now both of those will work.
|
…and it passed from a fork 🎉 |
|
Nice! 🍾 |
|
Smart. |
This was referenced Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes CI actually useful for PRs from forks.
Treat the versions that we need for tests as fixtures and store them in the repo instead of in an untracked cache on disk. This still preserves the ability to automagically grab new ones, but the credentials are only required if you’re doing that, which is extremely rare and should now never happen in CI.
Skip the PageFreezer diff tests. We don’t actually use that diff, so requiring everyone to have PF credentials and to run these tests seems unnecessary. (Still keeping the test around so folks with credentials can run it if needed.)