Skip to content

Disable auto-analysis of new versions #1090

Closed

Description

A big goal from long ago was to provide useful automated analyses of changes to help analysts and others prioritize what to look at. We originally did that with AnalyzeChangeJob, which is scheduled automatically after every import and create annotation records for every consecutive pair of versions:

if AnalyzeChangeJob.supported?
begin
@added.uniq(&:uuid).each do |version|
AnalyzeChangeJob.perform_later(version) if version.different?
end
rescue Redis::CannotConnectError => error
Rails.logger.error "Import #{import.id}: Cannot queue AnalyzeChangeJob -- #{error.message}"
end
else
Rails.logger.warn "Import #{import.id}: Auto-analysis requirements are not configured; AnalyzeChangeJobs were not scheduled for imported versions."
end

However, the analysis provided by that job always fell short (for a variety of reasons), and the problems it was meant to solve were ultimately better handled by web-monitoring-task-sheets. AnalyzeChangeJob is still running after every import, though! It’s doing a lot of work and generating a lot of data nobody never uses, so it’s probably time to disable it.

(NB: in an ideal world, we’d have better integrated the task sheets stuff so it ran automatically and posted results as annotations available through the API here, but that never happened for a whole other set of reasons. At this point, we are putting the project to rest, and it no longer makes sense to try and better integrate these tools.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions