Update tsconfig + add lint to CI

edgedb · Sep 4, 2023 · 971ef68 · 971ef68
1 parent c847d9a
commit 971ef68
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 8 deletions.
diff --git a/.github/workflows/ci_build.yml b/.github/workflows/ci_build.yml
@@ -28,6 +28,11 @@ jobs:
         run: |
           yarn
 
+      - name: Lint
+        working-directory: web
+        run: |
+          yarn lint
+
       - name: Run build
         working-directory: web
         run: |

diff --git a/web/package.json b/web/package.json
@@ -34,7 +34,8 @@
     "test": "jest --runInBand",
     "eject": "react-scripts eject",
     "dev-server": "env EDGEDB_DEBUG_HTTP_INJECT_CORS=1 edb server",
-    "open-browser": "node openBrowser.js"
+    "open-browser": "node openBrowser.js",
+    "lint": "tsc --noEmit"
   },
   "eslintConfig": {
     "extends": [

diff --git a/web/tests/_globalSetup.ts b/web/tests/_globalSetup.ts
@@ -54,7 +54,7 @@ async function checkUIServerAlive() {
         resolve(false);
       }
     });
-    req.on("error", (err) => {
+    req.on("error", () => {
       req.destroy();
       resolve(false);
     });

diff --git a/web/tests/queryEditor.test.ts b/web/tests/queryEditor.test.ts
@@ -1,9 +1,4 @@
-import {
-  ByUIClass,
-  goToPage,
-  waitUntilElementNotLocated,
-  uiClass,
-} from "./_utils";
+import {ByUIClass, goToPage, waitUntilElementNotLocated} from "./_utils";
 
 describe("queryEditor:", () => {
   beforeAll(async () => {

diff --git a/web/tsconfig.json b/web/tsconfig.json
@@ -12,6 +12,8 @@
     "allowSyntheticDefaultImports": true,
     "strict": true,
     "forceConsistentCasingInFileNames": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true,
     "module": "esnext",
     "moduleResolution": "node",