Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of currupted portable edgedb-server binaries #1358

Open
aljazerzen opened this issue Aug 8, 2024 · 0 comments
Open

Improve handling of currupted portable edgedb-server binaries #1358

aljazerzen opened this issue Aug 8, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@aljazerzen
Copy link
Contributor

In some weird cases, the portable distribution of edgedb-server might get corrupted. One possible way is interruption of the download/unpacking or interference of anti-virus software.

We had one such case reported here: https://discord.com/channels/841451783728529451/1270461080765993031

$ edgedb server install
edgedb error: error installing EdgeDB
  Caused by: metadata error for "/home/edgedb/.local/share/edgedb/portable/5.6"
  Caused by: cannot read "/home/edgedb/.local/share/edgedb/portable/5.6/install_info.json"
  Caused by: EOF while parsing a value at line 1 column 0 

In such scenarios, I suggest that the CLI displays the following message:

Error: corrupted installation of edgedb-server version 5.6
Do you want to remove this installation? [y/N]

If confirmed, the cli should then perform an uninstall.


Additionally, when the install is corrupted, it cannot be uninstalled:

$ edgedb server uninstall 5.6
[2024-08-07T19:18:31Z WARN  edgedb::portable::local] Skipping "/home/edgedb/.local/share/edgedb/portable/5.6": cannot read "/home/edgedb/.local/share/edgedb/portable/5.6/install_info.json": EOF while parsing a value at line 1 column 0
Nothing to uninstall.

... which is a bug and should be fixed.

@aljazerzen aljazerzen added bug Something isn't working enhancement New feature or request labels Aug 8, 2024
@aljazerzen aljazerzen changed the title Suggest removal of currupted portable edgedb-server binaries Improve handling of currupted portable edgedb-server binaries Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant