Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr command not working in Ventura 13.0 + Alfred 5.0.3 [2087] #52

Open
iltaek opened this issue Oct 27, 2022 · 7 comments
Open

pr command not working in Ventura 13.0 + Alfred 5.0.3 [2087] #52

iltaek opened this issue Oct 27, 2022 · 7 comments
Labels

Comments

@iltaek
Copy link

iltaek commented Oct 27, 2022

When I try to use pr command, it is switched to web search mode.

FYI. this is the OS version and I am using Alfred 5.0.3 [2087]

$ sw_vers
ProductName:		macOS
ProductVersion:		13.0
BuildVersion:		22A380

pr

CleanShot 2022-10-28 at 05 42 05@2x

[05:48:54.424] Logging Started...
[05:49:00.731] GitHub Repos[Script Filter] Queuing argument ''
[05:49:01.381] GitHub Repos[Script Filter] Script with argv '' finished
[05:49:01.388] ERROR: GitHub Repos[Script Filter] Code 1: exception object expected
[05:49:01.389] ERROR: GitHub Repos[Script Filter] JSON error: JSON text did not start with array or object and option to allow fragments not set. around line 1, column 0. in JSON:
exception object expected

pr asdf

CleanShot 2022-10-28 at 06 03 36@2x

[05:59:20.715] GitHub Repos[Script Filter] Queuing argument 'asdf'
[05:59:21.242] GitHub Repos[Script Filter] Script with argv 'asdf' finished
[05:59:21.251] ERROR: GitHub Repos[Script Filter] Code 1: exception object expected
@edgarjs edgarjs added the bug label Oct 27, 2022
@iltaek iltaek changed the title pr command not working in Ventura 13.0 pr command not working in Ventura 13.0 + Alfred 5.0.3 [2087] Oct 27, 2022
@dportalesr
Copy link

Seeing this too.

$ sw_vers
ProductName: macOS
ProductVersion: 13.3
ProductVersionExtra: (b)
BuildVersion: 22E7752300g

Alfred 5.0.6 [2110]

@roeniss
Copy link

roeniss commented Apr 25, 2023

Hi @edgarjs, I wonder whether this alfred-github-repos project has been abandoned or still maintained.

If it's latter case, I want to take on this issue (and other I hope).

So what's current state of this project? In other words, can you review my patch if i make pr?

@edgarjs
Copy link
Owner

edgarjs commented Apr 25, 2023

Hi @roeniss, I've been a little busy with other projects at the moment. I'd appreciate if you can send a PR and I'll review it gladly. Thank you.

@roeniss
Copy link

roeniss commented May 1, 2023

I'm confused because I failed to reproduce this issue lol. I see no problem here.

@dportalesr @iltaek Did you guys set your Personal Access Token properly with gh-login $PAT command? I think I didn't set it when I added the above comment. The token need to have repo section permissions.

edit: here's my spec:

$ sw_vers
ProductName:		macOS
ProductVersion:		13.2.1
BuildVersion:		22D68

and alfred 5.1 [2134]

@roeniss
Copy link

roeniss commented May 2, 2023

I'm not sure the exact reason but today succeded to reproduce with another computer, another organization. maybe kind of buffer overflow because some pr are shown and others are not.

@dportalesr
Copy link

@roeniss Yes, I have set it before. I also suspected it was something related to permissions so I created a new GH token but no luck. That newest token was configured like this
Menubar-20230608-005917

@dportalesr
Copy link

I found this note in Managing your personal access tokens

Note: Organization owners can restrict the access of personal access token (classic) to their organization. If you try to use a personal access token (classic) to access resources in an organization that has disabled personal access token (classic) access, your request will fail with a 403 response. Instead, you must use a GitHub App, OAuth App, or fine-grained personal access token.

Now, I'm not so versed in Alfred workflows to verify if that's the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants