Bug fixes

Author: ed7coyne

src/FirebaseArduino.cpp

@@ -61,7 +61,7 @@ void FirebaseArduino::setBool(const String& path, bool value) {
 }
 
 void FirebaseArduino::setString(const String& path, const String& value) {
-  JsonVariant json(value);
+  JsonVariant json(value.c_str());
   set(path, json);
 }
 

src/FirebaseArduino.h

@@ -17,6 +17,10 @@
 #ifndef FIREBASE_ARDUINO_H
 #define FIREBASE_ARDUINO_H
 
+#include <string>
+// This is needed to compile std::string on esp8266.
+template class std::basic_string<char>;
+
 #include "Firebase.h"
 #include "FirebaseObject.h"
 

src/FirebaseHttpClient_Esp8266.cpp

@@ -1,7 +1,8 @@
-#include <sstream>
 
 #include "FirebaseHttpClient.h"
 
+#include <stdio.h>
+
 // The ordering of these includes matters greatly.
 #include <WiFiClientSecure.h>
 #include <ESP8266WiFi.h>
@@ -60,9 +61,9 @@ class FirebaseHttpClientEsp8266 : public FirebaseHttpClient {
 
   std::string errorToString(int error_code) override {
 #ifdef USE_ESP_ARDUINO_CORE_2_0_0
-    std::ostringstream ss;
-    ss << error_code;
-    return ss.str();
+    char buff[11];
+    itoa(error_code, buff, 10);
+    return buff;
 #else
     return HTTPClient::errorToString(error_code).c_str();
 #endif

test/Makefile

@@ -51,5 +51,6 @@ firebase-test: ${OBJS}
 check: firebase-test
 	./firebase-test
 
+#TODO: had to echo this because it picks up FirebaseObject.h as well and deletes it :(
 clean:
 	echo rm -f ${OBJS} firebase-test