From 6132dcf79dd5df017a264b5058a2fbda21d29dda Mon Sep 17 00:00:00 2001 From: Ezekiel Warren Date: Wed, 29 Jan 2025 16:25:01 -0800 Subject: [PATCH 1/2] fix: entity created event first * the event created event was happening _after_ init,update, and remove component events. The correct order is supposed to be create, init, update, remove and then destroy --- rt_entt_codegen/core/events.cc | 20 ++++++++++---------- test/.bazelversion | 1 + 2 files changed, 11 insertions(+), 10 deletions(-) create mode 100644 test/.bazelversion diff --git a/rt_entt_codegen/core/events.cc b/rt_entt_codegen/core/events.cc index 01e1e18..f441761 100644 --- a/rt_entt_codegen/core/events.cc +++ b/rt_entt_codegen/core/events.cc @@ -38,6 +38,11 @@ auto ecsact::rt_entt_codegen::core::print_trigger_ecsact_events_minimal( // ) .return_type("void"); + ctx.write( + "ecsact::entt::wrapper::core::_trigger_create_entity_events(registry_id, " + "events_collector);\n" + ); + for(auto comp_id : comps_with_caps(details, ECSACT_SYS_CAP_ADDS)) { auto type_name = cpp_identifier(decl_full_name(comp_id)); print_trigger_event_fn_call(ctx, "init", type_name); @@ -53,11 +58,6 @@ auto ecsact::rt_entt_codegen::core::print_trigger_ecsact_events_minimal( // print_trigger_event_fn_call(ctx, "remove", type_name); } - ctx.write( - "ecsact::entt::wrapper::core::_trigger_create_entity_events(registry_id, " - "events_collector);\n" - ); - ctx.write( "ecsact::entt::wrapper::core::_trigger_destroy_entity_events(registry_id, " "events_collector);\n" @@ -81,6 +81,11 @@ auto ecsact::rt_entt_codegen::core::print_trigger_ecsact_events_all( // ) .return_type("void"); + ctx.write( + "ecsact::entt::wrapper::core::_trigger_create_entity_events(registry_id, " + "events_collector);\n" + ); + for(auto component_id : details.all_components) { auto type_name = cpp_identifier(decl_full_name(component_id)); print_trigger_event_fn_call(ctx, "init", type_name); @@ -101,11 +106,6 @@ auto ecsact::rt_entt_codegen::core::print_trigger_ecsact_events_all( // print_trigger_event_fn_call(ctx, "remove", type_name); } - ctx.write( - "ecsact::entt::wrapper::core::_trigger_create_entity_events(registry_id, " - "events_collector);\n" - ); - ctx.write( "ecsact::entt::wrapper::core::_trigger_destroy_entity_events(registry_id, " "events_collector);\n" diff --git a/test/.bazelversion b/test/.bazelversion new file mode 100644 index 0000000..815da58 --- /dev/null +++ b/test/.bazelversion @@ -0,0 +1 @@ +7.4.1 From b87d0c542da376310c613f8843666e6b2ac0839d Mon Sep 17 00:00:00 2001 From: Ezekiel Warren Date: Wed, 29 Jan 2025 16:25:49 -0800 Subject: [PATCH 2/2] chore(version): 0.3.17 --- CHANGELOG.md | 6 ++++++ MODULE.bazel | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6292829..30acfe7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,12 @@ All notable changes to this project will be documented in this file. See [conventional commits](https://www.conventionalcommits.org/) for commit guidelines. - - - +## 0.3.17 - 2025-01-30 +#### Bug Fixes +- entity created event first - (6132dcf) - Ezekiel Warren + +- - - + ## 0.3.16 - 2025-01-22 #### Miscellaneous Chores - allow ecsact_runtime 0.8.x - (7ba25dc) - Ezekiel Warren diff --git a/MODULE.bazel b/MODULE.bazel index 60e10bd..b0031d7 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -1,6 +1,6 @@ module( name = "ecsact_rt_entt", - version = "0.3.16", + version = "0.3.17", compatibility_level = 3, )