Feature/troika #90
Open
Feature/troika #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oiffrig
reviewed
Jul 31, 2025
| name, | ||
| user, | ||
| troika_exec="%TROIKA:troika%", | ||
| troika_config="%TROIKA_CONFIG%", |
There was a problem hiding this comment.
Is the value of TROIKA_CONFIG set somewhere?
There was a problem hiding this comment.
It is set by default on all our ecflow servers. I agree it would break when users don't set this variable at the suite or server level but I can't find a good way of setting it. What I could also do is provide None as default and provide the %TROIKA_CONFIG% value in wellies instead, which is more ECMWF-centric. We could do the same with troika_exec and provide only troika as default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvement of the troika constructor, setting default version to 0.2.3 (default on ecflow servers), and putting meaningless default values for the troika_exec and troika_config options.
Contributor Declaration
By opening this pull request, I affirm the following: