refactor: move code to prepare for observations #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feat/recipe-generator
…o feat/recipe-generator
…t/move-code-to-prepare-for-observations
MeraX
reviewed
Nov 18, 2025
| "grid_definition": { | ||
| "icon": { | ||
| "path": gridfile, | ||
| "refinement_level_c": input_refinement_level_c, |
Contributor
There was a problem hiding this comment.
Thanks for fixing this inconsistency. I think in general there is no need to set refinement_level_c for the icon grid_definition as the grid must always correspond to the grib data. Thus I would make the following suggestion:
Suggested change
| "refinement_level_c": input_refinement_level_c, | |
| "refinement_level_c": None, |
If I understood the earthkit team correctly, they are working on supporting ICON grids. I.e. it will be possible to ask EKD for the grid definition, making the icon grid_definition in anemoi-datatests unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a PR to prepare for the observations support. This PR merely move files around, so a lot of files are affected, but there should not be any code change. This prepares for further PRs that may affect the code more. This should be kinder on reviewers.
Naming conventions proposed here:
Move from "create" -> "build"
Introduce two types of datasets to be built:
gridded & tabular
What problem does this change solve?
What issue or task does this change relate to?
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.