GPIOs that number is larger than 512 cannot trigger interrupt #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default MRAA_SUB_PLATFORM_BIT_SHIFT is 9, so the sub‑platform mask is 1<<9 (512).
As a result, any GPIO number ≥512 is treated as a sub‑platform GPIO and its interrupt
is skipped, e.g. in `src/gpio/gpio.c`:
```
/* Is this pin on a subplatform? Do nothing... */
if (mraa_is_sub_platform_id(dev->pin)) {
}
```
On Linux 6.12 the GPIO numbering starts at 512, which is expected, but this makes mraa
ignore all GPIO interrupts on that platform.
see <path-to-linux6.12-src>/include/gpio.h for more details about GPIO numbering on
Linux 6.12:
```
/*
* At the end we want all GPIOs to be dynamically allocated from 0.
* However, some legacy drivers still perform fixed allocation.
* Until they are all fixed, leave 0-512 space for them.
*/
#define GPIO_DYNAMIC_BASE 512
```
This commit raises MRAA_SUB_PLATFORM_BIT_SHIFT to 12 (mask = 1<<12 = 4096),
so native GPIO numbers up to 4096 work correctly, while preserving existing
sub‑platform behavior and without changing the type of the pin member in
struct _gpio, maximizing forward compatibility.
Signed-off-by: Chun Jiao Zhao <chunjiao.zhao@siemens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default MRAA_SUB_PLATFORM_BIT_SHIFT is 9, so the sub‑platform mask is 1<<9 (512). As a result, any GPIO number ≥512 is treated as a sub‑platform GPIO and its interrupt is skipped, e.g. in
src/gpio/gpio.c:On Linux 6.12 the GPIO numbering starts at 512, which is expected, but this makes mraa ignore all GPIO interrupts on that platform.
see <path-to-linux6.12-src>/include/gpio.h for more details about GPIO numbering on Linux 6.12:
This commit raises MRAA_SUB_PLATFORM_BIT_SHIFT to 12 (mask = 1<<12 = 4096), so native GPIO numbers up to 4096 work correctly, while preserving existing sub‑platform behavior and without changing the type of the pin member in struct _gpio, maximizing forward compatibility.