Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FIFO (try)recv{,_deadline,_timeout} return ZResult<Option<T>> #1521

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

fuzzypixelz
Copy link
Member

@fuzzypixelz fuzzypixelz commented Oct 8, 2024

The changes in #1504 removed the flume error types; in zenoh all errors are Box<dyn std::error::Error> (for what it's worth). For distinguishing "disconnected" and "empty/timeout" channel errors, an Option is used, exactly like RingChannelHandler.

I believe we could've used proper error types, but it's too late for that now.

@fuzzypixelz fuzzypixelz added enhancement Existing things could work better breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) labels Oct 8, 2024
@eclipse-zenoh eclipse-zenoh deleted a comment from github-actions bot Oct 8, 2024
@fuzzypixelz fuzzypixelz enabled auto-merge (squash) October 8, 2024 14:37
@fuzzypixelz fuzzypixelz merged commit e9f3b37 into main Oct 8, 2024
23 checks passed
@fuzzypixelz fuzzypixelz deleted the hide-flume-fixup branch October 18, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) enhancement Existing things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants