Does the session get closed if a ReplyError is sent between multiple replies?

[pojiro]

I’m writing a thin Elixir wrapper around Zenoh 1.4.0.
While testing the wrapper, I sometimes encounter a flaky test when sending multiple replies along with a ReplyError.
This doesn't happen without ReplyError.

❓ My question is:

Does sending a ReplyError between two normal replies cause the session or query to be closed internally?
Or is there something else that might explain this intermittent "sending on a closed channel" error?

---

Here is the test:

    test "get/reply with ReplyError", %{session_id: session_id} do
      # Pass `self()` so that the queryable sends incoming queries to this test process.
      {:ok, queryable_id} = Zenohex.Session.declare_queryable(session_id, "key/expr", self())

      task = Task.async(Zenohex.Session, :get, [session_id, "key/expr/**", 100])

      # queryable send the `get` query to this test process. so receive it.
      assert_receive %Zenohex.Query{
        encoding: nil,
        key_expr: "key/expr/**",
        parameters: "",
        payload: nil,
        zenoh_query: zenoh_query
      }

      # then reply multipletimes
      :ok = Zenohex.Query.reply(zenoh_query, "key/expr/1", <<1>>, final?: false)
      :ok = Zenohex.Query.reply_error(zenoh_query, <<2>>, final?: false)
      # Send response final by passing `final?: true`, this drops the zenoh_query
      :ok = Zenohex.Query.reply(zenoh_query, "key/expr/3", <<3>>, final?: true)

      # get the replies
      assert {:ok, replies} = Task.await(task)

      # Check equality ignoring order
      assert MapSet.new(replies) ==
               MapSet.new([
                 %Zenohex.Sample{
                   key_expr: "key/expr/1",
                   payload: <<1>>
                 },
                 %Zenohex.Query.ReplyError{
                   payload: <<2>>,
                   encoding: "zenoh/bytes"
                 },
                 %Zenohex.Sample{
                   key_expr: "key/expr/3",
                   payload: <<3>>
                 }
               ])
    end

When the test fails, I see the following log messages.

[zenoh::api::handlers::fifo] error=sending on a closed channel

Following is the test failed result, got a only ReplyError.

  1) test peer mode get/reply with ReplyError (ZenohexTest)
     test/zenohex_test.exs:96
     Assertion with == failed
     code:  assert MapSet.new(replies) ==
              MapSet.new([
                %Zenohex.Sample{key_expr: "key/expr/1", payload: <<1>>},
                %Zenohex.Query.ReplyError{payload: <<2>>, encoding: "zenoh/bytes"},
                %Zenohex.Sample{key_expr: "key/expr/3", payload: <<3>>}
              ])
     left:  MapSet.new([%Zenohex.Query.ReplyError{payload: <<2>>, encoding: "zenoh/bytes"}])
     right: MapSet.new([%Zenohex.Query.ReplyError{payload: <<2>>, encoding: "zenoh/bytes"}, %Zenohex.Sample{attachment: nil, congestion_control: :block, encoding: "zenoh/bytes", express: false, key_expr: "key/expr/1", kind: :put, payload: <<1>>, priority: :data, timestamp: nil}, %Zenohex.Sample{attachment: nil, congestion_control: :block, encoding: "zenoh/bytes", express: false, key_expr: "key/expr/3", kind: :put, payload: <<3>>, priority: :data, timestamp: nil}])
     stacktrace:
       test/zenohex_test.exs:121: (test)

[pojiro]

I close this question, because I can't reproduce this in Rust zenoh.
https://github.com/pojiro/zenoh_repro_reply_error