-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WARNING] Mirror tool: Problems resolving provisioning plan #1052
Comments
Yep this warning is quite annoying and confusing, sometimes it cause issues, sometimes not. I'll take a look at it, can you tell if the issue also arise with 3.x snapshot? |
I haven't tried with the 3.x SNAPSHOT. Is there an explanation how to do this quickly? |
See try out the current tycho snapshot build. Snapshot generally also include newer eclipse releases so we can easier see if there is a bug maybe fixed by P2 already. |
Ah, I remember and had it prepared already from previous reports. The same issue occurs with 3.0.0-SNAPSHOT |
Okay thanks, I'll try to take a look at it. |
@fipro78 it seems your example is missing some files:
I also added a Maybe you can transform your example into an integration-test to demonstrate the issue? |
@laeubi sorry, this is an export issue on my side. I have updated the example with the corresponding .mvn folder and the parent pom.xml I will try to create an integration test based on this. Will see how far I can get here. But to show the error fast, I attached the complete example now. |
Just some observations: The
but the artifact itself has a maven version of Another one might be that the product is based on plugins and most (if not all) our tests using feature based products, so again here, either Tycho or MirrorApp might not handle plugin based products well. |
Another possible issue is that we do not make the maven items correctly available to the mirrorapp... sadly the mirror app uses some strange handling of the artifacts. |
Yes, the Bundle-Version and the Maven artifact version differ in the detail that the qualifier part is missing in the Maven artifact version. IIRC for publishing to Maven Central the .qualifier should be removed as this is an information that Maven does not use. Should Tycho in such a case not also avoid inspecting the qualifier information? Or at least have a fallback to search for the version without qualifier if the artifact with qualifier in the version is not found. I think plugin based products are totally valid, especially if you want to extract a small dedicated set of plugins to create a service runtime with plain OSGi instead of the Eclipse feature based thing. In that case the integration test will be even more helpful as it would cover an additional aspect. |
Yes tycho should work with this, and yes tycho should support plugin based products, I just think these aspects are (not yet) very well covered :-) |
I have created #1085 and hope that it works. I struggled the whole day with the setup. I followed the contribution documentation, but the Import as well as the Update of the project leads to endless loops and strange errors in the IDE I don't get fully. The project itself can be build in the project folder and shows the described error. If the integration in the test suite works I can't tell unfortunately. If it doesn't work give me a hint and I will try to fix it. Not sure what the issue is with the project setup on my side. |
@laeubi Any update on this? The test case is provided and actually fails as it shows the bug. :) On setting up another project I ran into the same issue and remembered that I already reported this. |
@fipro78 sorry I was not yet able to look into this yet :-\ |
I played around a bit with the example and it seems there is a specific problem with this artifact other maven items works fine and one can reproduce it with this simplified product:
Funny enough tycho seems to be able to resolve the version in the product processing part, so I fear this has to do with the "maven repository blackboard key" somehow (what remembers me we should really get rid of it) @mickaelistria are you aware of some code in that area that might have a problem with the fact that the @fipro78 can you try reducing your example even more? As mentioned above the product can be simplified and the api+impl bundles are not required to reproduce the problem, you can even remove
including the compile and runtime dependencies so we get a much smaller reproducer. |
@mickaelistria I think this is also a good example for what we need to solve when we want to allow Manifest Version != pom.xml version story. |
I don't remember sorry. I'd need to investigate that and I'm currently more focused on other bits of code. |
I finally found the problem is in
where in this example there are some warnings:
I have not find out yet why these are only warnings, but this results in the repository missing the
and finally
At first one might argue to simply treat warnings as error... but it is unclear if there are maybe warnings that can be ignored ... so this seems a very dangerous change. Beside that, the real limitation is the Mirror/DirectorApplication itself as we require here to do some hacks to pass the content to it for install that could better reuse the full target itself. The relevant Method here is
|
In my case, I have a project of type eclipse-repository with a category.xml file to generate an update site with our product's features and plugins. The message looks like this for me:
I'm not sure where that The category.xml file was made using the category editor in Eclipse which doesn't complain about anything. I would consider this message an error because the update site is missing the feature now. |
in lsp4j we see this with a plugin in category.xml
the category.xml has
and the feature.xml we also package
|
@fipro78 This is caused by missing requirements in the target, but Tycho does not correctly fails the resolve see: |
@cdietrich @kjsmita6 the issue you describing is most likely fixed by: |
Hi,
I have a small PDE based project with a Tycho build that should show how to publish an OSGi service via JAX-RS Whiteboard (Aries implementation). As the Aries implementation is only available via Maven and not via a p2 update site, I use the Maven locations in the target definition. Inside the IDE everything works as expected, the target definition resolves, the product definition is correctly setup, validates and I can start the product inside the IDE.
But the build using pom-less Tycho fails. I get the following warning:
then the build fails with this message:
The explanation in the wiki talks about feature patches, but the example is a plug-in based product without features. So I am not sure what causes the issue and how it could be solved.
I have the minimal example attached to reproduce the issue.
jaxrs_pde_example.zip
The text was updated successfully, but these errors were encountered: