Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve linting & prettier settings #8

Open
danielpeintner opened this issue Mar 15, 2024 · 1 comment
Open

Improve linting & prettier settings #8

danielpeintner opened this issue Mar 15, 2024 · 1 comment

Comments

@danielpeintner
Copy link
Member

Note: coming from #7 (comment)

I noticed some shortcoming w.r.t. to the current setup.

  • in node-wot we used to have eslint-plugin-unused-imports. I think having this might be useful
  • I also noticed that "npm run lint" does not screem if I have unused variables in my code. Useful again I think.
  • I also wonder whether prettier & linting should be based on language level (hence moving it into the /node directory )
@egekorkan
Copy link
Member

I also wonder whether prettier & linting should be based on language level (hence moving it into the /node directory )

I agree with this one.

For the other two, I am fine with aligning with node-wot here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants