Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isThingModel is too permissive #880

Open
egekorkan opened this issue Nov 24, 2022 · 2 comments
Open

isThingModel is too permissive #880

egekorkan opened this issue Nov 24, 2022 · 2 comments
Labels
td-tools Issues with axillary tools for node-wot thing-model

Comments

@egekorkan
Copy link
Member

There is a function called isThingModel in the td-tools package at https://github.com/eclipse/thingweb.node-wot/blob/master/packages/td-tools/src/thing-model-helpers.ts#L91

There are a couple of if conditions after line 107 that can result in a document recognized as a TM even if the document does not have tm:thingModel in the @type. I do not understand why those checks are added but if I am not wrong, everything after line 107 should be deleted and an else should be added instead that returns false.

@danielpeintner danielpeintner added td-tools Issues with axillary tools for node-wot thing-model labels Nov 25, 2022
@danielpeintner
Copy link
Member

@relu91 @lukesmolo any opinion?

@lukesmolo
Copy link
Contributor

Unfortunately I can't remember precisely, but this was a point of discussion with @relu91, so let me add him here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
td-tools Issues with axillary tools for node-wot thing-model
Projects
None yet
Development

No branches or pull requests

3 participants