Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack skipped for td-tools #1089

Open
relu91 opened this issue Sep 19, 2023 · 2 comments
Open

Webpack skipped for td-tools #1089

relu91 opened this issue Sep 19, 2023 · 2 comments
Labels
bug Something isn't working question Further information is requested td-tools Issues with axillary tools for node-wot

Comments

@relu91
Copy link
Member

relu91 commented Sep 19, 2023

I noticed that with the new build process (the one that leverages simply on typescript project feature), the webpack compilation in the td-tools package is skipped. In theory, this would cause the inability to use the package https://www.npmjs.com/package/@node-wot/td-tools outside of Node.js. I wondering if anybody noticed, @danielpeintner @egekorkan.

@relu91 relu91 added bug Something isn't working question Further information is requested td-tools Issues with axillary tools for node-wot labels Sep 19, 2023
@danielpeintner
Copy link
Member

I noticed that with the new build process (the one that leverages simply on typescript project feature), the webpack compilation in the td-tools package is skipped

I am definitely not aware that td-tools is skipped.
What do you mean by "new build process" ? Am I missing something here?

@relu91
Copy link
Member Author

relu91 commented Sep 20, 2023

I while ago we used the npm workspaces approach when building the whole code base. In practice, doing a npm run build implied that npm run the same command in all packages iteratively. For the td-tools package, the build script does a typescript build and then calls webpack. The new approach uses tsc -b && npm run build -w packages/browser-bundle, without calling the buildscript inside td-tools. I noticed that td-tools is also exposed inside the browser bundle so probably not many people use it as a direct dependency... but still it should be possible to use it as it is in browsers too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested td-tools Issues with axillary tools for node-wot
Projects
None yet
Development

No branches or pull requests

2 participants