Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor binding finder #17

Closed
egekorkan opened this issue May 4, 2024 · 3 comments · Fixed by #29
Closed

Refactor binding finder #17

egekorkan opened this issue May 4, 2024 · 3 comments · Fixed by #29
Assignees
@hasanheroglu

Comments

@egekorkan
Copy link
Member

egekorkan commented May 4, 2024 •
edited
Loading

After the discussions today, a real solution will take some time land and I would not want to block this PR. I propose to merge this PR and create an issue to track this. Once eclipse-thingweb/td-tools#18 is done, we can do the work to integrate it here. @danielpeintner @relu91 any opinions?

Originally posted by @egekorkan in #16 (comment)
@egekorkan
Copy link
Member Author

eclipse-thingweb/td-tools#18 will tackle this

@egekorkan
Copy link
Member Author

With https://www.npmjs.com/package/@thingweb/td-utils published, we can use it here now.

@hasanheroglu
Copy link
Contributor

I'll handle this.

@hasanheroglu hasanheroglu mentioned this issue Jul 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hasanheroglu hasanheroglu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use detectProtocolSchemes from @thingweb/td-utils for check… hasanheroglu/node-red
2 participants
@egekorkan @hasanheroglu