Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate Preferences Widget When Opened by Command #9355

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #9354 by activating the preferences widget when it is opened on command.

How to test

  1. Use the keyboard shortcut (ctrl + ,) to open the preferences widget.
  2. Observe that the searchbar is focused.

Review checklist

Reminder for reviewers

Signed-off-by: Colin Grant colin.grant@ericsson.com

Signed-off-by: Colin Grant <colin.grant@ericsson.com>
@colin-grant-work colin-grant-work added the preferences issues related to preferences label Apr 14, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@colin-grant-work colin-grant-work merged commit 8c9fb88 into eclipse-theia:master Apr 14, 2021
@colin-grant-work colin-grant-work deleted the bugfix/pref-widget-activation branch April 14, 2021 20:14
@vince-fugnitto vince-fugnitto added this to the 1.13.0 milestone Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preferences Widget Not Focused When Revelealed
2 participants