download-plugins: fix logging of failures #8798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Because Array.forEach(f) calls f with (currentValue, index, array), the output
was not only the messages, but also the index and full array.
This changes to log only the message.
How to test
Change
theiaPlugins
inpackage.json
to something like this:run
yarn download:plugins
. Without this change, in the output there is the index and the array of failures, it looks like this:After this change, the output is:
Review checklist
Reminder for reviewers