8349-support-vscode-settings-schemas

[danarad05]

Signed-off-by: Dan Arad dan.arad@sap.com

What it does

fixes: #8349 #8673

How to test

Open a workspace and check if there are warnings concerning "vscode://schemas/settings/folder" schema.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[danarad05]

@akosyakov @vince-fugnitto
cc: @amiramw
In regards to issue #8349:

1. I have added registration of workspaceSchema and folderSchema uri (user,launch, task exist already). Is that what you meant in 8349?
2. Also there are some other scopes - 'application' | 'machine' | 'window' | 'resource' | 'language-overridable' | 'machine-overridable' which I'm not sure if should be added.
3. Also, Should I update code using getCombinedSchema()?

• for instance generateTree() in preference-tree-generator.ts has entire logic for building pref tree based on combinedSchema.
• also updateUnderlyingData in preference-tree-provider.ts is based on combinedSchema for hiding/showing properties for preferences pages.

Thanks

[amiramw]

1. I have added registration of workspaceSchema and folderSchema uri (user,launch, task exist already). Is that what you meant in 8349?

I think it is good enough scope for this PR. Not sure about 8349. There can be future work done on preference UI like vscode that shows all folders in workspace and their specific preferences.

2. Also there are some other scopes - 'application' | 'machine' | 'window' | 'resource' | 'language-overridable' | 'machine-overridable' which I'm not sure if should be added.

Maybe le'ts keep it workspace and folder for now.

How to test
TBD

There should one less warning on problem view about missing schema for folder.

[danarad05]

@amiramw see my comments - updated. Please review again.
Thanks

Also, please rerun again second build (Error: The process '/usr/bin/xvfb-run' failed with exit code 1) Thanks.

[amiramw]

@danarad05 i see now that the warning about folder scehma is gone. However there are more warnings now than before for some reason. Please check.
Before:

Now:

[danarad05]

@amiramw

@danarad05 i see now that the warning about folder scehma is gone. However there are more warnings now than before for some reason. Please check.

After "vscode://schemas/settings/folder" is now fixed, builtin extension "vscode.json-language-features" is now able to load it's contents and run validation on it.

[amiramw]

For the scope of eliminating constant problem about missing schema and for showing extra warnings coming from settings folder schema this PR is good enough and seems to work fine.

There is additional work for embedding it in preference UI etc. (like in vs code). But it can be done later IMO.