[core][monaco] Implement Save without Formatting command

[DucNgn]

What it does

Fixes: #8375

• Implements the command Save without Formatting New command: Save without formatting #8375
• Adds key binding of ctrlcmd+k s to save without formatting

How to test

• Make changes to a file (might be in wrong format/convention to better observe the functionality)
• Use key binding: ctrlcmd+k s or choose from the command palette the option Save without Formatting
• Expected behavior: The document is saved, but not formatted by the editor.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Duc Nguyen duc.a.nguyen@ericsson.com

[vince-fugnitto]

The changes work very well with me, and I'm happy with the approach 👍
I'll give it time for others to review as well, we can potential include it after the release.

[vince-fugnitto]

@kittaakos whenever you have an opportunity would you mind reviewing as well?

[DucNgn]

I updated this PR with minor changes in variable name and documentation (as recommended by @vince-fugnitto #8554 (comment))

[kittaakos]

@dukengn, as I see VS Code does not have a menu item Save without formatting, this breaks the UX for downstream.

If we often break the UX, downstream will opt-out from Theia as the maintenance is problematic.

[vince-fugnitto]

@dukengn, as I see VS Code does not have a menu item Save without formatting, this breaks the UX for downstream.
If we often break the UX, downstream will opt-out from Theia as the maintenance is problematic.

Sorry about that @kittaakos, I should have picked it up during the review.

For the future, I assume that adding new menu items which are also present in vscode is considered as the only non-breaking UX changes acceptable for downstream apps? Or, do you believe we should advertise (changelog) all menu changes as breaking UX, and even be cautious about including them in the framework.

[kittaakos]

Sorry about that @kittaakos, I should have picked it up during the review.

No problem at all.

or the future, I assume that adding new menu items which are also present in vscode is considered as the only non-breaking UX changes acceptable for downstream apps?

We all should agree on something that fits for all of us. Let's have a dev call about it next year.