-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
application-package: remove unused test #8295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
quality
issues related to code and application quality
test
issues related to unit and api tests
labels
Aug 3, 2020
the following commit removes the method `isOutdated` from `ExtensionPackage` along with it's unit-test as it is deprecated and no longer used. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/extension-package-tests
branch
from
August 3, 2020 19:07
51c60d5
to
09848db
Compare
kittaakos
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
can be also removed. |
The following commit removes the `ExtensionPackage.getLatestVersion` method as it is unused and untested. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
The following commit removes the `getVersionRange` method which is currently unused and untested. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
The following commit removes the method `resolveVersionRange` which is unused and untested. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Thank you! I've removed the unused code in my latest changes. |
marcdumais-work
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Vince
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8285
The following pull-request removes the
ExtensionPackage#isOutdated
method along with it's unit test.Motivation
isOutdated
is no longer used (no callers present in the repo)npm
(which is not ideal for a test case)How to test
Verify that CI successfully passes.
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com