Upgrade vscode-ripgrep's yarn.lock entry so we pick-up latest #8280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
marcdumais-work
changed the title
vscode-ripgrep's yarn.lock entry so we pick-up latest
vince-fugnitto
added
the
dependencies
vince-fugnitto
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
The changes look good, it should fix the main repo build for anyone who uses a proxy.
For example: #8282
It also is more permissive and allows downstream applications to use the vscode-ripgrep version which best suits them.
Fixes #8171 This will benefit the developres that build our example application behind a firewall, since now `ripgrep` respects environment proxy settings. Extenders can upgrade their own application's `yarn.lock` since this change will not affect them. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
force-pushed
the
unpin-ripgrep
branch
from
4c06758
to
5024bdd
Compare
|
Thanks for the review @vince-fugnitto . Can you have another quick look? I thought it would be good to add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Upgrade
vscode-ripgrep's yarn.lock entry so we pick-up latestThis will benefit the developers that build our example application behind a firewall, since
vscode-ripgreprecently supports operating system environment proxy settings:microsoft/vscode-ripgrep#10
Extenders can upgrade their own application's
yarn.locksince this change will not directly affect themFixes #8171
How to test
Build using
yarnand confirm thatvscode-ripgrepwe pull is now1.8.0:Test that
search-in-workspaceandfile-searchstill workReview checklist
Reminder for reviewers