-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scm: add api integration tests #8231
Conversation
Yes, tests like that 👍 I would be very interested to get good tests for navigation. It is a struggle to make sure that all cases are working, see this PR for instance: #8084 I don't think it fixes #7581. The description says that keyboard navigation is particularly interesting to be tested, since it breaks often. Having good SCM API for navigation will be also good, like |
sorry, wrong button |
ef3494c
to
90b51a4
Compare
@akosyakov thank you for the review, would it be acceptable to include the following tests as a basis for |
sure! |
the following commit includes api integration tests for `scm`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@akosyakov thank you for your help and feedback during the reviews, I have addressed your latest comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
What it does
The following pull-request introduces basic API integration tests for
SCM
.How to test
Verify that the API tests pass successfully.
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com