Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scm: add api integration tests #8231

Merged
merged 1 commit into from
Aug 3, 2020
Merged

scm: add api integration tests #8231

merged 1 commit into from
Aug 3, 2020

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Jul 24, 2020

What it does

The following pull-request introduces basic API integration tests for SCM.

How to test

Verify that the API tests pass successfully.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added test issues related to unit and api tests scm issues related to the source control manager labels Jul 24, 2020
@vince-fugnitto vince-fugnitto self-assigned this Jul 24, 2020
@akosyakov
Copy link
Member

akosyakov commented Jul 28, 2020

Yes, tests like that 👍 I would be very interested to get good tests for navigation. It is a struggle to make sure that all cases are working, see this PR for instance: #8084

I don't think it fixes #7581. The description says that keyboard navigation is particularly interesting to be tested, since it breaks often.

Having good SCM API for navigation will be also good, like ScmContribution.goToNextResource and so on.

@akosyakov akosyakov closed this Jul 28, 2020
@akosyakov
Copy link
Member

sorry, wrong button

@akosyakov akosyakov reopened this Jul 28, 2020
@vince-fugnitto
Copy link
Member Author

Yes, tests like that I would be very interested to get good tests for navigation. It is a struggle to make sure that all cases are working, see this PR for instance: #8084

I don't think it fixes #7581. The description says that keyboard navigation is particularly interesting to be tested, since it breaks often.

Having good SCM API for navigation will be also good, like ScmContribution.goToNextResource and so on.

@akosyakov thank you for the review, would it be acceptable to include the following tests as a basis for SCM and think about how we can add and test APIs for navigation (ex: ScmContribution.goToNextResource) in subsequent pull-requests (I removed the fixes tag)? Is there anything else you'd like to include as part of this initial suite?

@akosyakov
Copy link
Member

@akosyakov thank you for the review, would it be acceptable to include the following tests as a basis for SCM and think about how we can add and test APIs for navigation (ex: ScmContribution.goToNextResource) in subsequent pull-requests (I removed the fixes tag)? Is there anything else you'd like to include as part of this initial suite?

sure!

the following commit includes api integration tests for `scm`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto
Copy link
Member Author

@akosyakov thank you for your help and feedback during the reviews, I have addressed your latest comments.
Please re-review whenever you get an opportunity to do so :)

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@vince-fugnitto vince-fugnitto merged commit fedb5f3 into master Aug 3, 2020
@vince-fugnitto vince-fugnitto deleted the vf/scm branch August 3, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scm issues related to the source control manager test issues related to unit and api tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants