terminal: fix xterm opacity issue #8204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #8158 The following commit addresses an issue with newer versions of `xterm` which displayed a secondary cursor-like border due to our global `:focus` class. The fix updates the xterm textarea to force an opacity consistent with their sources. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added
terminal
Anasshahidd21
approved these changes
Jul 20, 2020
|
I have shamelessly stolen the fix and applied it to a downstream project. I can confirm; it works great with |
kittaakos
approved these changes
Jul 20, 2020
This was referenced Jul 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8158
The following pull-request addresses an issue present in newer versions of
xtermwhich displayed a secondary cursor-like border caused by our global:focusclass. The fix includes updating the styling of thextermtextarea to force an opacity consistent with their sources and resolve the UI error.How to test
xtermdependency to version^4.8.0and consequently update theyarn.lockas well (or use a resolution block to pin the version of xterm)Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com