Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debug] Save the dirty editor when starting launch config #8115

Merged
merged 1 commit into from
Jul 1, 2020
Merged

[debug] Save the dirty editor when starting launch config #8115

merged 1 commit into from
Jul 1, 2020

Conversation

Anasshahidd21
Copy link
Contributor

@Anasshahidd21 Anasshahidd21 commented Jun 29, 2020 •
edited
Loading

What it does

Fixes: #7938

Saves all the editors when starting to debug in Theia.

How to test

  1. Open Theia as a workspace.
  2. Make changes to a test file(make sure the test fails), and without saving use the debugger to Run Mocha Test
  3. Check your filesystem to see if the changes for the file are saved or not.
  4. Check to see if the test is failing

Signed-off-by: Anas Shahid muhammad.shahid@ericsson.com

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the debug issues that related to debug functionality label Jun 29, 2020
@Anasshahidd21 Anasshahidd21 force-pushed the saveWhileDebug branch 3 times, most recently from 1944d65 to 03b4f05 Compare June 29, 2020 23:52
@akosyakov akosyakov requested a review from kittaakos June 30, 2020 06:43
[debug] Save the dirty editor when starting launch config
ad65372 
Fixes: eclipse-theia#7938

Saves all the editors when starting to debug in Theia.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
@akosyakov
Copy link
Member

oh sorry, I meant to ping @vince-fugnitto could you test again please

vince-fugnitto
vince-fugnitto approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well, the dirty editors are saved when debugging 👍

@vince-fugnitto vince-fugnitto merged commit 64244a5 into eclipse-theia:master Jul 1, 2020
@vince-fugnitto vince-fugnitto deleted the saveWhileDebug branch July 1, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov left review comments

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@kittaakos kittaakos Awaiting requested review from kittaakos

Assignees
No one assigned
Labels
debug issues that related to debug functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[debug] Save the dirty editor when starting launch config
3 participants
@Anasshahidd21 @akosyakov @vince-fugnitto