preferences: update 'modified scope'

[vince-fugnitto]

What it does

The following pull-request updates the preferences-view to properly display the 'modified scope' message when a preference is updated from it's default value in a different scope (between user and workspace only at the moment).

Viewing 'User' - 'Workspace' Updated:

Viewing 'Workspace' - 'User' Updated:

Both Scopes Updated:

The following pull-request updates the preferences modified scope
message to display messages in the user tab when there are updates to
the preference in the workspace scope.

How to test

1. open the preferences-view
2. modify preferences in the user, workspace scope and verify that the message works properly

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

[colin-grant-work]

Thanks for finding this bug and addressing it so quickly. I've encountered to odd behaviors. One I've remarked on below, and the other is that I'm getting the message in Workspace scope about User scope even when the values are the same and both are default:

Here's application.confirmExit in User unmodified

And the same preference in Workspace, also unmodified:

Since this is only happening with certain preferences and not all, I think it may be related to #7685 , since application.confirmExit is a preference that seems almost never to fire an event in User scope. That's probably beyond the scope of this PR, but worth noting as an additional symptom of that issue.

[lmcbout]

Works fine
Suggestion: In the tab which apply the new preference, there is a Blue line (Before the preference) showing this preference is modified in settings,json. In the other tab (User | Workspace) you display a string beside the pref ( Modified in: User) Can we make this string in Blue so it would be more visible when scrolling through the preference? It would make this PR Better

[vince-fugnitto]

Works fine
Suggestion: In the tab which apply the new preference, there is a Blue line (Before the preference) showing this preference is modified in settings,json. In the other tab (User | Workspace) you display a string beside the pref ( Modified in: User) Can we make this string in Blue so it would be more visible when scrolling through the preference? It would make this PR Better

@lmcbout the blue line (on the left side of the preference) indicates that the preference is updated from it's default. If you are viewing a different scope (and it has the default value) the blue line is not visible (similarly to vscode).

For example, in vscode it is the same:

[lmcbout]

The Blue line is fine where you modified the preference setting, but can we have a more distinctive indicator in the other preference view than just adding the "Modified in: User" beside the preference?

If so, this would be better to see the preference is modified in the other scope

[Anasshahidd21]

The changes work well on my side.
Tested both when there are changes done in both the scopes for a certain extension, as well as when changes are made only to one scope.

[vince-fugnitto]

@colin-grant-work are you fine with the latest changes? :)

[colin-grant-work]

@vince-fugnitto, Yes, taken another look, and everything is working nicely. Well done!

[vince-fugnitto]

I'll merge the pull-request tomorrow if there are no objections.